Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.70.0 #1774

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Release/0.70.0 #1774

merged 11 commits into from
Jan 11, 2024

Conversation

harishv7
Copy link
Contributor

v0.70.0

  • IS-846 fix copy for new rte #1769
  • fix: header spacing #1772
  • fix(cards): prevent overflowing of cards by enforcing width #1771
  • Chore/upgrade axios #1767
  • feat(codeowner): make life easier #1765
  • chore: fix styling for review request files #1764
  • chore: reset staging url when privatising site #1763
  • fix(styles): fix overlapping page title issue #1762
  • fix(media): enhance bulk delete for media images #1753
  • release/0.69.0 #1759

harishv7 and others added 11 commits December 21, 2023 16:07
@harishv7
Merge pull request #1759 from isomerpages/release/0.69.0
16593c7 
release/0.69.0
@dcshzj
fix(media): enhance bulk delete for media images (#1753)
f649a86
@sehyunidaaa
fix(styles): fix overlapping page title issue (#1762)
f728a80 
* fix(styles): fix overlapping page title issue

* clean up whitespaces and indentation

* fix flex properties

---------

Co-authored-by: Park Se Hyun <>
@alexanderleegs
chore: reset staging url when privatising site (#1763)
37bcb8c
@alexanderleegs
chore: fix styling for review request files (#1764)
8445bd9
@kishore03109
feat(codeowner): make life easier (#1765)
9de5184
@alexanderleegs
Chore/upgrade axios (#1767)
bb50c33 
* chore: upgrade axios

* fix: error messages and shape
@dcshzj
fix(cards): prevent overflowing of cards by enforcing width (#1771)
01e0a41
@alexanderleegs
fix: header spacing (#1772)
5e81fa8
@harishv7
IS-846 fix copy for new rte (#1769)
1c22a59 
* feat: update markdown edit page with new copy

* feat: more copy changes

* feat: use infobox

* chore: remove unused imports

* feat: add copy on new editor page

* fix: copy changes

* fix: add conditional to show infobox on editor

* fix: design review changes
@harishv7
0.70.0
5e94ef6
@mergify Mergify
Copy link

mergify bot commented Jan 10, 2024

⚠️ The sha of the head commit of this PR conflicts with #1773. Mergify cannot evaluate rules on this PR. ⚠️

@cypress Cypress
Copy link

cypress bot commented Jan 10, 2024

59 failed tests on run #480 ↗︎

59 49 1 22 Flakiness 0

Details:

Release/0.70.0
Project: isomercms-frontend Commit: 5e94ef6b42
Status: Failed Duration: 16:16 💡
Started: Jan 10, 2024 1:53 PM Ended: Jan 10, 2024 2:09 PM
Failed  editPage.spec.ts • 10 failed tests

View Output Video

Test Artifacts
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add existing image Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to upload and add new image Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to upload and add new file Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add existing file Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add link Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow users to add Instagram embed script Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add untrusted external scripts Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add inline scripts Screenshots Video
editPage.spec > Edit collection page > Edit page (collection) should have correct colour Screenshots Video
editPage.spec > Edit resource page > Edit page (resource) should have correct colour Screenshots Video
Failed  files.spec.ts • 10 failed tests

View Output Video

Test Artifacts
Files > Create file, delete file, edit file settings in Files > Files should contain Directories and Ungrouped Files Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to create new file with valid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to edit a file Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to create file with invalid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to edit file and save with invalid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to delete file Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to create new file directory Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to edit file directory name Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to delete file directory Screenshots Video
Files > Create file, delete file, edit file settings, and move files in file directories > Should be able to add file to file directory Screenshots Video
Failed  folders.spec.ts • 9 failed tests

View Output Video

Test Artifacts
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to delete a sub-folder with a page Screenshots Video
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to delete a sub-folder without page Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to create a new page with valid title and permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid title Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Chinese title and valid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Tamil title and valid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to delete existing page in folder Screenshots Video
Folders flow > Create page, delete page, edit page settings in subfolder > Should be able to create a new page with valid title and permalink Screenshots Video
Failed  homepage.spec.ts • 6 failed tests

View Output Video

Test Artifacts
Homepage > Block editing > should display the site notification correctly Screenshots Video
Homepage > Block editing > should only allow up to 4 highlights for the hero section Screenshots Video
Homepage > Block editing > should remove the button in preview when the hero button content is not given Screenshots Video
Homepage > Block editing > should preserve content when swapping between highlights and dropdown for hero section Screenshots Video
Homepage > Block editing > should limit users to a single resource component Screenshots Video
Homepage > Block editing > should rearrange the blocks correctly and the preview should also reflect the new order Screenshots Video
Failed  images.spec.ts • 1 failed test

View Output Video

Test Artifacts
Images > Create album, delete album, edit album settings in Images > Should be able to create new album Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

Review all test suite changes for PR #1774 ↗︎

@harishv7 harishv7 merged commit cff63f5 into master Jan 11, 2024
31 of 35 checks passed
@mergify mergify bot deleted the release/0.70.0 branch January 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

@alexanderleegs alexanderleegs Awaiting requested review from alexanderleegs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harishv7 @dcshzj @sehyunidaaa @alexanderleegs @kishore03109